Difference between revisions of "T240307: Hook container with strong types and DI"

Latest revision as of 19:35, 6 October 2021

Phabricator Link	T240307
Status	resolved
Priority	Medium (orange)
Points
Phabricator Task Created	2019/12/10 12:07 AM
Wiki Page Created	2019/12/10 12:44 AM
Phabricator Task Last Modified	2021/10/06 07:37 PM
Wiki Page Last Updated	2021/10/06 08:35 PM
Phabricator Task Closed	2021/02/25 05:33 PM
Authored By	tstarling (Tim Starling)
Assigned To	tstarling (Tim Starling)
Projects	Dependency injection MW-1.31-release-notes MW-1.33-notes MW-1.34-notes MW-1.35-notes (1.35.0-wmf.35; 2020-06-02) MediaWiki-Core-Hooks (HookRunner) Patch-For-Review Platform Engineering (Tech Planning Review) Platform Team Initiatives (New Hook System) Platform Team Workboards (Epics) (Epic Backlog) TechCom-RFC (TechCom-RFC-Closed) (Approved) User-Daniel (Inbox)
Platform Engineering Initiative Column	New Hook System
Platform Team Workboards Column	Epics: Epic Backlog
Subtasks	T246855: Hook interface doc comment review (resolved) T250859: Rename BeforeParserrenderImageGalleryHook to BeforeParserRenderImageGalleryHook (open) T252686: extension.json did not pass validation: The property HookHandlers is not defined and the definition does not allow additional properties (resolved) T253768: No easy way to suppress hard-deprecation warnings for hooks (open) T254053: MediaWikiTestCaseTrait::createHookContainer failing mediawiki-quibble-composer-mysql-php72-docker (resolved) T257196: Allow tests to reset/clear non-legacy hook handlers (duplicate) T258665: Document canonical hook name in hook interfaces (resolved)
Parent Tasks	T252798: How should hook implementations access the current request context? T254271: Should HookRunner be in the service container?

Column Transitions: (Added project: ⇑, Removed project: ⇓,Entered column: ⇒, Exited column: ⇐)

Project	Column	Date
⇑ Platform Engineering		10 December 2019
⇑ TechCom-RFC		10 December 2019
⇑ User-Daniel		11 December 2019
TechCom-RFC	⇐ P1: Define	11 December 2019
TechCom-RFC	⇒ Under discussion	11 December 2019
TechCom-RFC	⇐ Under discussion	9 January 2020
TechCom-RFC	⇒ P5: Last Call	9 January 2020
Platform Engineering	⇐ Inbox	16 January 2020
Platform Engineering	⇒ Future Initiatives/Small Projects	16 January 2020
⇓ TechCom-RFC		22 January 2020
⇑ TechCom-RFC (TechCom-RFC-Closed)		22 January 2020
⇑ Patch-For-Review		10 February 2020
TechCom-RFC (TechCom-RFC-Closed)	⇐ Untriaged	19 February 2020
TechCom-RFC (TechCom-RFC-Closed)	⇒ Approved	19 February 2020
⇑ MW-1.35-notes (1.35.0-wmf.23; 2020-03-10)		5 March 2020
⇑ Platform Team Workboards (Clinic Duty Team)		18 March 2020
Platform Team Workboards (Clinic Duty Team)	⇐ Inbox	18 March 2020
Platform Team Workboards (Clinic Duty Team)	⇒ Waiting for Review	18 March 2020
⇑ Dependency injection		20 March 2020
⇑ MediaWiki-Core-Hooks		11 April 2020
⇓ MW-1.35-notes (1.35.0-wmf.23; 2020-03-10)		20 April 2020
⇑ MW-1.35-notes (1.35.0-wmf.30; 2020-04-28)		20 April 2020
⇓ MW-1.35-notes (1.35.0-wmf.30; 2020-04-28)		5 May 2020
⇑ MW-1.35-notes (1.35.0-wmf.31; 2020-05-05)		5 May 2020
Platform Team Workboards (Clinic Duty Team)	⇐ Waiting for Review	12 May 2020
Platform Team Workboards (Clinic Duty Team)	⇒ Doing(WIP:5)	12 May 2020
⇑ Platform Team Initiatives (New Hook System)		19 May 2020
⇓ MW-1.35-notes (1.35.0-wmf.31; 2020-05-05)		25 May 2020
⇑ MW-1.35-notes (1.35.0-wmf.34; 2020-05-26)		25 May 2020
⇑ MW-1.33-notes		26 May 2020
⇑ MW-1.34-notes		26 May 2020
⇑ MW-1.31-release-notes		26 May 2020
⇓ MW-1.35-notes (1.35.0-wmf.34; 2020-05-26)		1 June 2020
⇑ MW-1.35-notes (1.35.0-wmf.35; 2020-06-02)		1 June 2020
⇓ Patch-For-Review		1 June 2020
⇑ Patch-For-Review		10 June 2020
MediaWiki-Core-Hooks	⇐ Untriaged	24 July 2020
MediaWiki-Core-Hooks	⇒ HookRunner	24 July 2020
Platform Engineering	⇐ Future Initiatives/Small Projects	26 August 2020
Platform Engineering	⇒ Tech Planning Review	26 August 2020
Platform Team Workboards (Clinic Duty Team)	⇐ Doing(WIP:5)	26 August 2020
Platform Team Workboards (Clinic Duty Team)	⇒ Discussing	26 August 2020
⇓ Platform Team Workboards (Clinic Duty Team)		1 September 2020
⇑ Platform Team Workboards (Epics)		1 September 2020
Platform Engineering	⇐ Tech Planning Review	28 January 2021
Platform Engineering	⇒ Tech Planning Review	28 January 2021
Platform Engineering	⇐ Tech Planning Review	3 February 2021
Platform Engineering	⇒ Tech Planning Review	3 February 2021

@@ Line 1: / Line 1: @@
 {{Phabricator Task
 |name=Hook container with strong types and DI
-|status=open
+|status=resolved
 |color=orange
 |points=
 |dateCreated=1575954444
-|dateModified=1587139868
+|dateModified=1633563473
+|dateClosed=1614292414
 |author={{Phabricator User
 |type=author
+|username=tstarling
+|realName=Tim Starling
+}}
+|owner={{Phabricator User
+|type=owner
 |username=tstarling
 |realName=Tim Starling
@@ Line 13: / Line 19: @@
 |projects={{Phabricator Project
 |name=MW-1.35-notes
-|column=1.35.0-wmf.23; 2020-03-10
+|column=1.35.0-wmf.35; 2020-06-02
+|entryDate=1575954444
+}}{{Phabricator Project
+|name=Dependency injection
 |entryDate=1575954444
 }}{{Phabricator Project
-|name=Core Platform Team Workboards (Clinic Duty Team)
+|name=Platform Team Workboards (Epics)
-|column=Waiting for Review
+|column=Epic Backlog
-|entryDate=1584551584
+|entryDate=1575954444
+}}{{Phabricator Project
+|name=MW-1.31-release-notes
+|entryDate=1575954444
 }}{{Phabricator Project
-|name=Core Platform Team
+|name=MW-1.33-notes
-|column=Future Initiatives/Small Projects
+|entryDate=1575954444
-|entryDate=1579200745
 }}{{Phabricator Project
-|name=Dependency injection
+|name=MW-1.34-notes
 |entryDate=1575954444
 }}{{Phabricator Project
 |name=MediaWiki-Core-Hooks
-|column=Backlog
+|column=HookRunner
+|entryDate=1595620873
+}}{{Phabricator Project
+|name=Platform Team Initiatives
+|column=New Hook System
 |entryDate=1575954444
 }}{{Phabricator Project
 |name=Patch-For-Review
 |entryDate=1575954444
+}}{{Phabricator Project
+|name=Platform Engineering
+|column=Tech Planning Review
+|entryDate=1612381946
 }}{{Phabricator Project
 |name=TechCom-RFC (TechCom-RFC-Closed)
@@ Line 42: / Line 61: @@
 |entryDate=1575954444
 }}
-|subtasks=246855
+|subtasks=258665,257196,253768,252686,250859,254053,246855
 |transitions={{Transition
+|date=1612381946
+|type=Entered Column
+|project=Platform Engineering
+|column=Tech Planning Review
+}}{{Transition
+|date=1612381946
+|type=Exited Column
+|project=Platform Engineering
+|column=Tech Planning Review
+}}{{Transition
+|date=1611826549
+|type=Entered Column
+|project=Platform Engineering
+|column=Tech Planning Review
+}}{{Transition
+|date=1611826549
+|type=Exited Column
+|project=Platform Engineering
+|column=Tech Planning Review
+}}{{Transition
+|date=1598992640
+|type=Removed Project
+|project=Platform Team Workboards (Clinic Duty Team)
+}}{{Transition
+|date=1598992640
+|type=Added Project
+|project=Platform Team Workboards (Epics)
+}}{{Transition
+|date=1598435688
+|type=Entered Column
+|project=Platform Team Workboards (Clinic Duty Team)
+|column=Discussing
+}}{{Transition
+|date=1598435688
+|type=Exited Column
+|project=Platform Team Workboards (Clinic Duty Team)
+|column=Doing(WIP:5)
+}}{{Transition
+|date=1598435653
+|type=Entered Column
+|project=Platform Engineering
+|column=Tech Planning Review
+}}{{Transition
+|date=1598435653
+|type=Exited Column
+|project=Platform Engineering
+|column=Future Initiatives/Small Projects
+}}{{Transition
+|date=1595620873
+|type=Entered Column
+|project=MediaWiki-Core-Hooks
+|column=HookRunner
+}}{{Transition
+|date=1595620873
+|type=Exited Column
+|project=MediaWiki-Core-Hooks
+|column=Untriaged
+}}{{Transition
+|date=1591800828
+|type=Added Project
+|project=Patch-For-Review
+}}{{Transition
+|date=1591027885
+|type=Removed Project
+|project=Patch-For-Review
+}}{{Transition
+|date=1591027293
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.34; 2020-05-26)
+}}{{Transition
+|date=1591027293
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.35; 2020-06-02)
+}}{{Transition
+|date=1590508844
+|type=Added Project
+|project=MW-1.34-notes
+}}{{Transition
+|date=1590508844
+|type=Added Project
+|project=MW-1.31-release-notes
+}}{{Transition
+|date=1590508844
+|type=Added Project
+|project=MW-1.33-notes
+}}{{Transition
+|date=1590454859
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.31; 2020-05-05)
+}}{{Transition
+|date=1590454859
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.34; 2020-05-26)
+}}{{Transition
+|date=1589933854
+|type=Added Project
+|project=Platform Team Initiatives (New Hook System)
+}}{{Transition
+|date=1589292597
+|type=Entered Column
+|project=Platform Team Workboards (Clinic Duty Team)
+|column=Doing(WIP:5)
+}}{{Transition
+|date=1589292597
+|type=Exited Column
+|project=Platform Team Workboards (Clinic Duty Team)
+|column=Waiting for Review
+}}{{Transition
+|date=1588669262
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.30; 2020-04-28)
+}}{{Transition
+|date=1588669262
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.31; 2020-05-05)
+}}{{Transition
+|date=1587430825
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.23; 2020-03-10)
+}}{{Transition
+|date=1587430825
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.30; 2020-04-28)
+}}{{Transition
 |date=1586601572
 |type=Added Project
@@ Line 54: / Line 197: @@
 |date=1584551584
 |type=Entered Column
-|project=Core Platform Team Workboards (Clinic Duty Team)
+|project=Platform Team Workboards (Clinic Duty Team)
 |column=Waiting for Review
 }}{{Transition
 |date=1584551584
 |type=Exited Column
-|project=Core Platform Team Workboards (Clinic Duty Team)
+|project=Platform Team Workboards (Clinic Duty Team)
 |column=Inbox
 }}{{Transition
 |date=1584551574
 |type=Added Project
-|project=Core Platform Team Workboards (Clinic Duty Team)
+|project=Platform Team Workboards (Clinic Duty Team)
 }}{{Transition
 |date=1583427643
@@ Line 94: / Line 237: @@
 |date=1579200745
 |type=Entered Column
-|project=Core Platform Team
+|project=Platform Engineering
 |column=Future Initiatives/Small Projects
 }}{{Transition
 |date=1579200745
 |type=Exited Column
-|project=Core Platform Team
+|project=Platform Engineering
 |column=Inbox
 }}{{Transition
@@ Line 132: / Line 275: @@
 |date=1575954444
 |type=Added Project
-|project=Core Platform Team
+|project=Platform Engineering
 }}
 }}