Difference between revisions of "T249393: Deprecate methods returning Revision objects"

Latest revision as of 15:27, 16 January 2021

Phabricator Link	T249393
Status	resolved
Priority	Medium (orange)
Points
Phabricator Task Created	2020/04/03 09:17 PM
Wiki Page Created	2020/04/03 10:19 PM
Phabricator Task Last Modified	2020/07/09 07:18 PM
Wiki Page Last Updated	2021/01/16 03:27 PM
Phabricator Task Closed	2020/07/01 10:49 PM
Authored By	DannyS712
Assigned To	DannyS712
Projects	MW-1.35-notes (1.35.0-wmf.40; 2020-07-07) MediaWiki-Revision-backend (Untriaged) Platform Team Workboards (External Code Reviews) (External Code Review Needed) Technical-Debt (Deprecation process) (2020) User-DannyS712 (Resolved (deprecation))
Platform Engineering Initiative Column
Platform Team Workboards Column	External Code Reviews: External Code Review Needed
Subtasks	T248655: EditPage::getBaseRevision returns a revision (resolved) T249384: ParserOptions' currentRevisionCallback uses Revision objects (resolved) T249397: Replace LinksUpdate Revision methods with RevisionRecord (resolved) T249982: PageArchive::getRevision uses timestamp, suggested replacement uses rev id (resolved) T250249: WikiPage::insertProtectNullRevision returns Revision objects (resolved) T250431: ContribsPager::tryToCreateValidRevision returns Revision objects (resolved) T250532: Hard deprecate Article::getRevision and WikiPage::getRevision (resolved) T250638: Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus (declined) T251718: Hard deprecate PageArchive::getPreviousRevision (resolved) T251965: Deprecate use of Revision objects in WikiPage::doRollback and ::commitRollback (resolved) T253949: User::getNewMessageLinks can return Revision objects (resolved) T254952: PageUpdater: set DeprecatablePropertyArray to hard deprecate Revision (resolved)
Parent Tasks	T246284: Hard deprecate the Revision class

Column Transitions: (Added project: ⇑, Removed project: ⇓,Entered column: ⇒, Exited column: ⇐)

Project	Column	Date
⇑ Technical-Debt (Deprecation process)		3 April 2020
⇑ Platform Team Workboards (Clinic Duty Team)		3 April 2020
⇑ User-DannyS712		3 April 2020
⇑ MediaWiki-Revision-backend		3 April 2020
Technical-Debt (Deprecation process)	⇐ Untriaged	3 April 2020
Technical-Debt (Deprecation process)	⇒ 2020	3 April 2020
User-DannyS712	⇐ Unsorted	3 April 2020
User-DannyS712	⇒ In progress	3 April 2020
⇑ Patch-For-Review		3 April 2020
⇑ MW-1.35-notes (1.35.0-wmf.28; 2020-04-14)		7 April 2020
⇓ Platform Team Workboards (Clinic Duty Team)		10 April 2020
⇑ Platform Team Workboards (External Code Reviews)		10 April 2020
⇓ MW-1.35-notes (1.35.0-wmf.28; 2020-04-14)		15 April 2020
⇑ MW-1.35-notes (1.35.0-wmf.30; 2020-04-28)		15 April 2020
⇓ MW-1.35-notes (1.35.0-wmf.30; 2020-04-28)		28 April 2020
⇑ MW-1.35-notes (1.35.0-wmf.31; 2020-05-05)		28 April 2020
⇓ MW-1.35-notes (1.35.0-wmf.31; 2020-05-05)		10 June 2020
⇑ MW-1.35-notes (1.35.0-wmf.37; 2020-06-16)		10 June 2020
⇓ MW-1.35-notes (1.35.0-wmf.37; 2020-06-16)		24 June 2020
⇑ MW-1.35-notes (1.35.0-wmf.39; 2020-06-30)		24 June 2020
⇓ MW-1.35-notes (1.35.0-wmf.39; 2020-06-30)		1 July 2020
⇑ MW-1.35-notes (1.35.0-wmf.40; 2020-07-07)		1 July 2020
⇓ Patch-For-Review		1 July 2020
User-DannyS712	⇐ In progress	9 July 2020
User-DannyS712	⇒ Resolved (deprecation)	9 July 2020

@@ Line 1: / Line 1: @@
 {{Phabricator Task
 |name=Deprecate methods returning Revision objects
-|status=open
+|status=resolved
 |color=orange
 |points=
 |dateCreated=1585963057
-|dateModified=1591672083
+|dateModified=1594336705
+|dateClosed=1593658194
 |author={{Phabricator User
 |type=author
+|username=DannyS712
+|realName=
+}}
+|owner={{Phabricator User
+|type=owner
 |username=DannyS712
 |realName=
@@ Line 13: / Line 19: @@
 |projects={{Phabricator Project
 |name=MW-1.35-notes
-|column=1.35.0-wmf.31; 2020-05-05
+|column=1.35.0-wmf.40; 2020-07-07
 |entryDate=1585963057
 }}{{Phabricator Project
 |name=Technical-Debt (Deprecation process)
-|column=2020 | MW 1.35 / 1.36
+|column=2020 | MW 1.35
 |entryDate=1585963067
 }}{{Phabricator Project
-|name=Core Platform Team Workboards (External Code Reviews)
+|name=Platform Team Workboards (External Code Reviews)
 |column=External Code Review Needed
 |entryDate=1585963057
@@ Line 26: / Line 32: @@
 |name=MediaWiki-Revision-backend
 |column=Untriaged
-|entryDate=1585963057
-}}{{Phabricator Project
-|name=Patch-For-Review
 |entryDate=1585963057
 }}{{Phabricator Project
 |name=User-DannyS712
-|column=In progress
+|column=Resolved (deprecation)
-|entryDate=1585963074
+|entryDate=1594336705
 }}
-|subtasks=253949,251965,251718,250638,250532,250431,250249,249982,249397,249384,248655
+|subtasks=254952,253949,251965,251718,250638,250532,250431,250249,249982,249397,249384,248655
 |transitions={{Transition
+|date=1594336705
+|type=Entered Column
+|project=User-DannyS712
+|column=Resolved (deprecation)
+}}{{Transition
+|date=1594336705
+|type=Exited Column
+|project=User-DannyS712
+|column=In progress
+}}{{Transition
+|date=1593658194
+|type=Removed Project
+|project=Patch-For-Review
+}}{{Transition
+|date=1593637238
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.39; 2020-06-30)
+}}{{Transition
+|date=1593637238
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.40; 2020-07-07)
+}}{{Transition
+|date=1592971237
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.37; 2020-06-16)
+}}{{Transition
+|date=1592971237
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.39; 2020-06-30)
+}}{{Transition
+|date=1591761622
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.31; 2020-05-05)
+}}{{Transition
+|date=1591761622
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.37; 2020-06-16)
+}}{{Transition
 |date=1588129228
 |type=Removed Project
@@ Line 55: / Line 96: @@
 |date=1586532204
 |type=Removed Project
-|project=Core Platform Team Workboards (Clinic Duty Team)
+|project=Platform Team Workboards (Clinic Duty Team)
 }}{{Transition
 |date=1586532204
 |type=Added Project
-|project=Core Platform Team Workboards (External Code Reviews)
+|project=Platform Team Workboards (External Code Reviews)
 }}{{Transition
 |date=1586307627
@@ Line 82: / Line 123: @@
 |type=Entered Column
 |project=Technical-Debt (Deprecation process)
-|column=2020 | MW 1.35 / 1.36
+|column=2020 | MW 1.35
 }}{{Transition
 |date=1585963067
@@ Line 103: / Line 144: @@
 |date=1585963057
 |type=Added Project
-|project=Core Platform Team Workboards (Clinic Duty Team)
+|project=Platform Team Workboards (Clinic Duty Team)
 }}
 }}