Difference between revisions of "T246284: Hard deprecate the Revision class"

Latest revision as of 15:26, 16 January 2021

Phabricator Link	T246284
Status	resolved
Priority	Medium (orange)
Points
Phabricator Task Created	2020/02/26 03:02 PM
Wiki Page Created	2020/02/26 04:08 PM
Phabricator Task Last Modified	2020/09/11 03:13 PM
Wiki Page Last Updated	2021/01/16 03:26 PM
Phabricator Task Closed	2020/07/06 09:58 AM
Authored By	DannyS712
Assigned To	DannyS712
Projects	Epic MW-1.35-notes (1.35.0-wmf.40; 2020-07-07) MediaWiki-Revision-backend (Revision store) Platform Engineering (Triage Meeting Inbox) Platform Team Workboards (External Code Reviews) (External Code Review Needed) Technical-Debt (Deprecation process) (2020) User-DannyS712 (Resolved (deprecation))
Platform Engineering Initiative Column
Platform Team Workboards Column	External Code Reviews: External Code Review Needed
Subtasks	T248291: Hard deprecate not passing a user to Revision::get methods with Revision::FOR_THIS_USER (resolved) T249393: Deprecate methods returning Revision objects (resolved) T249434: Replace hooks using Revision objects with RevisionRecord (resolved) T249561: Deprecate methods accepting Revision objects as parameters (resolved) T250761: DifferenceEngine $mNewRev and $mOldRev are Revision objects (resolved) T250976: Deprecate access to Article::$mRevision (resolved) T251067: Hard deprecate individual Revision class methods [tracking] (resolved) T257010: Replace deployed uses of Revision constants (resolved) T257011: Audit and remove extension `use Revision;` declarations where possible (resolved) T257531: Cleanup forgotten usages of Revision (resolved)
Parent Tasks	T243708: Mediawiki core needs uses of global $wgUser removed

Column Transitions: (Added project: ⇑, Removed project: ⇓,Entered column: ⇒, Exited column: ⇐)

Project	Column	Date
⇑ User-DannyS712		26 February 2020
⇑ MediaWiki-Revision-backend		26 February 2020
⇑ Platform Engineering		26 February 2020
⇑ Epic		26 February 2020
⇑ Technical-Debt (Deprecation process)		26 February 2020
Technical-Debt (Deprecation process)	⇐ Untriaged	26 February 2020
Technical-Debt (Deprecation process)	⇒ 2020	26 February 2020
Platform Engineering	⇐ Inbox	27 February 2020
Platform Engineering	⇒ Triage Meeting Inbox	27 February 2020
⇑ Patch-For-Review		28 February 2020
User-DannyS712	⇐ Unsorted	28 February 2020
User-DannyS712	⇒ In progress	28 February 2020
⇑ MW-1.35-notes (1.35.0-wmf.22; 2020-03-03)		28 February 2020
⇓ Platform Engineering		3 March 2020
⇑ Platform Team Workboards (Clinic Duty Team)		3 March 2020
Platform Team Workboards (Clinic Duty Team)	⇐ Inbox	3 March 2020
Platform Team Workboards (Clinic Duty Team)	⇒ Waiting for Review	3 March 2020
⇓ MW-1.35-notes (1.35.0-wmf.22; 2020-03-03)		4 March 2020
⇑ MW-1.35-notes (1.35.0-wmf.24; 2020-03-17)		4 March 2020
⇓ MW-1.35-notes (1.35.0-wmf.24; 2020-03-17)		5 March 2020
⇑ MW-1.35-notes (1.35.0-wmf.23; 2020-03-10)		5 March 2020
⇑ Readers-Web-Backlog (Kanbanana-2019-20-Q3)		6 March 2020
Readers-Web-Backlog (Kanbanana-2019-20-Q3)	⇐ Needs Analysis	6 March 2020
Readers-Web-Backlog (Kanbanana-2019-20-Q3)	⇒ Needs Code Review	6 March 2020
Readers-Web-Backlog (Kanbanana-2019-20-Q3)	⇐ Needs Code Review	9 March 2020
Readers-Web-Backlog (Kanbanana-2019-20-Q3)	⇒ Needs Code Review	9 March 2020
Readers-Web-Backlog (Kanbanana-2019-20-Q3)	⇐ Needs Code Review	9 March 2020
Readers-Web-Backlog (Kanbanana-2019-20-Q3)	⇒ Needs Code Review	9 March 2020
MediaWiki-Revision-backend	⇐ Untriaged	9 March 2020
MediaWiki-Revision-backend	⇒ Revision store	9 March 2020
⇓ MW-1.35-notes (1.35.0-wmf.23; 2020-03-10)		11 March 2020
⇑ MW-1.35-notes (1.35.0-wmf.24; 2020-03-17)		11 March 2020
⇓ Readers-Web-Backlog (Kanbanana-2019-20-Q3)		11 March 2020
⇓ MW-1.35-notes (1.35.0-wmf.24; 2020-03-17)		19 March 2020
⇑ MW-1.35-notes (1.35.0-wmf.25; 2020-03-24)		19 March 2020
⇓ MW-1.35-notes (1.35.0-wmf.25; 2020-03-24)		24 March 2020
⇑ MW-1.35-notes (1.35.0-wmf.26; 2020-03-31)		24 March 2020
⇓ MW-1.35-notes (1.35.0-wmf.26; 2020-03-31)		31 March 2020
⇑ MW-1.35-notes (1.35.0-wmf.27; 2020-04-07)		31 March 2020
⇓ MW-1.35-notes (1.35.0-wmf.27; 2020-04-07)		14 April 2020
⇑ MW-1.35-notes (1.35.0-wmf.28; 2020-04-14)		14 April 2020
⇓ MW-1.35-notes (1.35.0-wmf.28; 2020-04-14)		15 April 2020
⇑ MW-1.35-notes (1.35.0-wmf.30; 2020-04-28)		15 April 2020
⇓ Platform Team Workboards (Clinic Duty Team)		15 April 2020
⇑ Platform Team Workboards (External Code Reviews)		15 April 2020
⇓ MW-1.35-notes (1.35.0-wmf.30; 2020-04-28)		28 April 2020
⇑ MW-1.35-notes (1.35.0-wmf.31; 2020-05-05)		28 April 2020
⇓ MW-1.35-notes (1.35.0-wmf.31; 2020-05-05)		5 May 2020
⇑ MW-1.35-notes (1.35.0-wmf.32; 2020-05-12)		5 May 2020
User-DannyS712	⇐ In progress	11 May 2020
User-DannyS712	⇒ Projects	11 May 2020
⇓ MW-1.35-notes (1.35.0-wmf.32; 2020-05-12)		30 May 2020
⇑ MW-1.35-notes (1.35.0-wmf.35; 2020-06-02)		30 May 2020
⇓ MW-1.35-notes (1.35.0-wmf.35; 2020-06-02)		3 June 2020
⇑ MW-1.35-notes (1.35.0-wmf.36; 2020-06-09)		3 June 2020
⇓ MW-1.35-notes (1.35.0-wmf.36; 2020-06-09)		10 June 2020
⇑ MW-1.35-notes (1.35.0-wmf.37; 2020-06-16)		10 June 2020
⇓ MW-1.35-notes (1.35.0-wmf.37; 2020-06-16)		22 June 2020
⇑ MW-1.35-notes (1.35.0-wmf.38; 2020-06-23)		22 June 2020
⇑ Platform Engineering		23 June 2020
⇓ MW-1.35-notes (1.35.0-wmf.38; 2020-06-23)		23 June 2020
⇑ MW-1.35-notes (1.35.0-wmf.39; 2020-06-30)		23 June 2020
⇓ Platform Engineering		24 June 2020
⇑ Platform Engineering		24 June 2020
⇓ MW-1.35-notes (1.35.0-wmf.39; 2020-06-30)		30 June 2020
⇑ MW-1.35-notes (1.35.0-wmf.40; 2020-07-07)		30 June 2020
User-DannyS712	⇐ Projects	2 July 2020
User-DannyS712	⇒ Awaiting review and deployment	2 July 2020
⇓ Patch-For-Review		6 July 2020
User-DannyS712	⇐ Awaiting review and deployment	9 July 2020
User-DannyS712	⇒ Resolved (deprecation)	9 July 2020

@@ Line 1: / Line 1: @@
 {{Phabricator Task
 |name=Hard deprecate the Revision class
-|status=open
+|status=resolved
-|color=violet
+|color=orange
 |points=
 |dateCreated=1582747372
-|dateModified=1583284795
+|dateModified=1599851614
+|dateClosed=1594043908
 |author={{Phabricator User
 |type=author
+|username=DannyS712
+|realName=
+}}
+|owner={{Phabricator User
+|type=owner
 |username=DannyS712
 |realName=
@@ Line 13: / Line 19: @@
 |projects={{Phabricator Project
 |name=MW-1.35-notes
-|column=1.35.0-wmf.22; 2020-03-03
+|column=1.35.0-wmf.40; 2020-07-07
 |entryDate=1582747372
-}}{{Phabricator Project
-|name=Core Platform Team
-|column=Triage Meeting Inbox
-|entryDate=1582812977
 }}{{Phabricator Project
 |name=Technical-Debt (Deprecation process)
-|column=2020 | MW 1.35 / 1.36
+|column=2020 | MW 1.35
 |entryDate=1582747383
 }}{{Phabricator Project
 |name=Epic
+|entryDate=1582747372
+}}{{Phabricator Project
+|name=Platform Team Workboards (External Code Reviews)
+|column=External Code Review Needed
 |entryDate=1582747372
 }}{{Phabricator Project
 |name=MediaWiki-Revision-backend
-|column=Untriaged
+|column=Revision store
-|entryDate=1582747372
+|entryDate=1583803940
 }}{{Phabricator Project
-|name=Patch-For-Review
+|name=Platform Engineering
-|entryDate=1582747372
+|column=Triage Meeting Inbox
+|entryDate=1582812977
 }}{{Phabricator Project
 |name=User-DannyS712
-|column=In progress
+|column=Resolved (deprecation)
-|entryDate=1582936276
+|entryDate=1594336368
 }}
+|subtasks=257531,248291,257011,257010,251067,250976,250761,249561,249434,249393
 |transitions={{Transition
+|date=1594336368
+|type=Entered Column
+|project=User-DannyS712
+|column=Resolved (deprecation)
+}}{{Transition
+|date=1594336368
+|type=Exited Column
+|project=User-DannyS712
+|column=Awaiting review and deployment
+}}{{Transition
+|date=1594043908
+|type=Removed Project
+|project=Patch-For-Review
+}}{{Transition
+|date=1593681365
+|type=Entered Column
+|project=User-DannyS712
+|column=Awaiting review and deployment
+}}{{Transition
+|date=1593681365
+|type=Exited Column
+|project=User-DannyS712
+|column=Projects
+}}{{Transition
+|date=1593518429
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.39; 2020-06-30)
+}}{{Transition
+|date=1593518429
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.40; 2020-07-07)
+}}{{Transition
+|date=1593037160
+|type=Added Project
+|project=Platform Engineering
+}}{{Transition
+|date=1593031727
+|type=Removed Project
+|project=Platform Engineering
+}}{{Transition
+|date=1592967622
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.38; 2020-06-23)
+}}{{Transition
+|date=1592967622
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.39; 2020-06-30)
+}}{{Transition
+|date=1592894922
+|type=Added Project
+|project=Platform Engineering
+}}{{Transition
+|date=1592820035
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.37; 2020-06-16)
+}}{{Transition
+|date=1592820035
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.38; 2020-06-23)
+}}{{Transition
+|date=1591801225
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.36; 2020-06-09)
+}}{{Transition
+|date=1591801225
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.37; 2020-06-16)
+}}{{Transition
+|date=1591228832
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.35; 2020-06-02)
+}}{{Transition
+|date=1591228832
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.36; 2020-06-09)
+}}{{Transition
+|date=1590825810
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.32; 2020-05-12)
+}}{{Transition
+|date=1590825810
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.35; 2020-06-02)
+}}{{Transition
+|date=1589224376
+|type=Entered Column
+|project=User-DannyS712
+|column=Projects
+}}{{Transition
+|date=1589224376
+|type=Exited Column
+|project=User-DannyS712
+|column=In progress
+}}{{Transition
+|date=1588726830
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.31; 2020-05-05)
+}}{{Transition
+|date=1588726830
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.32; 2020-05-12)
+}}{{Transition
+|date=1588100436
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.30; 2020-04-28)
+}}{{Transition
+|date=1588100436
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.31; 2020-05-05)
+}}{{Transition
+|date=1586969726
+|type=Removed Project
+|project=Platform Team Workboards (Clinic Duty Team)
+}}{{Transition
+|date=1586969726
+|type=Added Project
+|project=Platform Team Workboards (External Code Reviews)
+}}{{Transition
+|date=1586948437
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.28; 2020-04-14)
+}}{{Transition
+|date=1586948437
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.30; 2020-04-28)
+}}{{Transition
+|date=1586840424
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.27; 2020-04-07)
+}}{{Transition
+|date=1586840424
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.28; 2020-04-14)
+}}{{Transition
+|date=1585674032
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.26; 2020-03-31)
+}}{{Transition
+|date=1585674032
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.27; 2020-04-07)
+}}{{Transition
+|date=1585072830
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.25; 2020-03-24)
+}}{{Transition
+|date=1585072830
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.26; 2020-03-31)
+}}{{Transition
+|date=1584650846
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.24; 2020-03-17)
+}}{{Transition
+|date=1584650846
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.25; 2020-03-24)
+}}{{Transition
+|date=1583946791
+|type=Removed Project
+|project=Readers-Web-Backlog (Kanbanana-2019-20-Q3)
+}}{{Transition
+|date=1583938843
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.23; 2020-03-10)
+}}{{Transition
+|date=1583938843
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.24; 2020-03-17)
+}}{{Transition
+|date=1583803940
+|type=Entered Column
+|project=MediaWiki-Revision-backend
+|column=Revision store
+}}{{Transition
+|date=1583803940
+|type=Exited Column
+|project=MediaWiki-Revision-backend
+|column=Untriaged
+}}{{Transition
+|date=1583746779
+|type=Entered Column
+|project=Readers-Web-Backlog (Kanbanana-2019-20-Q3)
+|column=Needs Code Review
+}}{{Transition
+|date=1583746779
+|type=Exited Column
+|project=Readers-Web-Backlog (Kanbanana-2019-20-Q3)
+|column=Needs Code Review
+}}{{Transition
+|date=1583746777
+|type=Entered Column
+|project=Readers-Web-Backlog (Kanbanana-2019-20-Q3)
+|column=Needs Code Review
+}}{{Transition
+|date=1583746777
+|type=Exited Column
+|project=Readers-Web-Backlog (Kanbanana-2019-20-Q3)
+|column=Needs Code Review
+}}{{Transition
+|date=1583522660
+|type=Entered Column
+|project=Readers-Web-Backlog (Kanbanana-2019-20-Q3)
+|column=Needs Code Review
+}}{{Transition
+|date=1583522660
+|type=Exited Column
+|project=Readers-Web-Backlog (Kanbanana-2019-20-Q3)
+|column=Needs Analysis
+}}{{Transition
+|date=1583522648
+|type=Added Project
+|project=Readers-Web-Backlog (Kanbanana-2019-20-Q3)
+}}{{Transition
+|date=1583420390
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.24; 2020-03-17)
+}}{{Transition
+|date=1583420390
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.23; 2020-03-10)
+}}{{Transition
+|date=1583305243
+|type=Removed Project
+|project=MW-1.35-notes (1.35.0-wmf.22; 2020-03-03)
+}}{{Transition
+|date=1583305243
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.24; 2020-03-17)
+}}{{Transition
+|date=1583287194
+|type=Entered Column
+|project=Platform Team Workboards (Clinic Duty Team)
+|column=Waiting for Review
+}}{{Transition
+|date=1583287194
+|type=Exited Column
+|project=Platform Team Workboards (Clinic Duty Team)
+|column=Inbox
+}}{{Transition
+|date=1583287181
+|type=Removed Project
+|project=Platform Engineering
+}}{{Transition
+|date=1583287181
+|type=Added Project
+|project=Platform Team Workboards (Clinic Duty Team)
+}}{{Transition
 |date=1582948827
 |type=Added Project
@@ Line 59: / Line 315: @@
 |date=1582812977
 |type=Entered Column
-|project=Core Platform Team
+|project=Platform Engineering
 |column=Triage Meeting Inbox
 }}{{Transition
 |date=1582812977
 |type=Exited Column
-|project=Core Platform Team
+|project=Platform Engineering
 |column=Inbox
 }}{{Transition
@@ Line 70: / Line 326: @@
 |type=Entered Column
 |project=Technical-Debt (Deprecation process)
-|column=2020 | MW 1.35 / 1.36
+|column=2020 | MW 1.35
 }}{{Transition
 |date=1582747383
@@ Line 83: / Line 339: @@
 |date=1582747372
 |type=Added Project
-|project=Core Platform Team
+|project=Platform Engineering
 }}{{Transition
 |date=1582747372