Difference between revisions of "T251861: Move SpecialBlock::checkUnblockSelf to a block permissions service"

Latest revision as of 17:00, 22 April 2021

Phabricator Link	T251861
Status	resolved
Priority	Needs Triage (violet)
Points
Phabricator Task Created	2020/05/05 04:09 AM
Wiki Page Created	2020/05/05 05:12 AM
Phabricator Task Last Modified	2020/10/16 01:38 PM
Wiki Page Last Updated	2021/04/22 06:00 PM
Phabricator Task Closed	2020/07/28 05:41 PM
Authored By	Tchanders
Assigned To	Urbanecm
Projects	Anti-Harassment (The Letter Song) (Done: Q4 (2019-20)) MW-1.35-notes (1.35.0-wmf.38; 2020-06-23) MediaWiki-Blocks (Backlog) Platform Team Initiatives (Decoupling (CDP2)) (Backlog) Platform Team Workboards (External Code Reviews) (External Code Review Needed) Technical-Debt (Unsorted) User-Urbanecm (Waiting on review)
Platform Engineering Initiative Column
Platform Team Workboards Column	External Code Reviews: External Code Review Needed
Subtasks
Parent Tasks	T189073: Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere T250020: Refactor logic for doing and logging unblock out of SpecialUnblock so it can be easily reused elsewhere

Column Transitions: (Added project: ⇑, Removed project: ⇓,Entered column: ⇒, Exited column: ⇐)

Project	Column	Date
⇑ Anti-Harassment (The Letter Song)		5 May 2020
⇑ MediaWiki-Blocks		5 May 2020
⇑ Technical-Debt		5 May 2020
⇑ Platform Team Workboards (Clinic Duty Team)		5 May 2020
⇑ User-Urbanecm		5 May 2020
⇑ Platform Team Initiatives (Decoupling (CDP2))		5 May 2020
Anti-Harassment (The Letter Song)	⇐ Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW)	5 May 2020
Anti-Harassment (The Letter Song)	⇒ Code Review 🔍	5 May 2020
⇑ Patch-For-Review		7 May 2020
⇓ Platform Team Workboards (Clinic Duty Team)		8 May 2020
⇑ Platform Team Workboards (External Code Reviews)		8 May 2020
User-Urbanecm	⇐ Backlog	12 May 2020
User-Urbanecm	⇒ Working on	12 May 2020
Anti-Harassment (The Letter Song)	⇐ Code Review 🔍	14 May 2020
Anti-Harassment (The Letter Song)	⇒ Code Review 🔍	14 May 2020
User-Urbanecm	⇐ Working on	8 June 2020
User-Urbanecm	⇒ Waiting on review	8 June 2020
⇓ Patch-For-Review		16 June 2020
Anti-Harassment (The Letter Song)	⇐ Code Review 🔍	16 June 2020
Anti-Harassment (The Letter Song)	⇒ QA/Testing 🐞	16 June 2020
⇑ MW-1.35-notes (1.35.0-wmf.38; 2020-06-23)		16 June 2020
Anti-Harassment (The Letter Song)	⇐ QA/Testing 🐞	19 June 2020
Anti-Harassment (The Letter Song)	⇒ Done: Q4 (2019-20)	19 June 2020

@@ Line 1: / Line 1: @@
 {{Phabricator Task
 |name=Move SpecialBlock::checkUnblockSelf to a block permissions service
-|status=open
+|status=resolved
 |color=violet
 |points=
 |dateCreated=1588666140
-|dateModified=1588878739
+|dateModified=1602869904
+|dateClosed=1595972501
 |author={{Phabricator User
 |type=author
@@ Line 17: / Line 18: @@
 }}
 |projects={{Phabricator Project
-|name=Core Platform Team Workboards (Clinic Duty Team)
+|name=MW-1.35-notes
-|column=Inbox
+|column=1.35.0-wmf.38; 2020-06-23
 |entryDate=1588666140
 }}{{Phabricator Project
-|name=CPT Initiatives
+|name=Platform Team Initiatives (Decoupling (CDP2))
-|column=Decoupling (CDP2)
+|column=Backlog
+|entryDate=1588666140
+}}{{Phabricator Project
+|name=Platform Team Workboards (External Code Reviews)
+|column=External Code Review Needed
 |entryDate=1588666140
 }}{{Phabricator Project
 |name=MediaWiki-Blocks
 |column=Backlog
-|entryDate=1588666140
-}}{{Phabricator Project
-|name=Patch-For-Review
 |entryDate=1588666140
 }}{{Phabricator Project
@@ Line 37: / Line 39: @@
 }}{{Phabricator Project
 |name=Anti-Harassment (The Letter Song)
-|column=Review
+|column=Done: Q4 (2019-20)
-|entryDate=1588669140
+|entryDate=1592575714
 }}{{Phabricator Project
 |name=User-Urbanecm
-|column=Backlog
+|column=Waiting on review
-|entryDate=1588666140
+|entryDate=1591640595
 }}
 |transitions={{Transition
+|date=1592575714
+|type=Entered Column
+|project=Anti-Harassment (The Letter Song)
+|column=Done: Q4 (2019-20)
+}}{{Transition
+|date=1592575714
+|type=Exited Column
+|project=Anti-Harassment (The Letter Song)
+|column=QA/Testing 🐞
+}}{{Transition
+|date=1592323238
+|type=Added Project
+|project=MW-1.35-notes (1.35.0-wmf.38; 2020-06-23)
+}}{{Transition
+|date=1592321804
+|type=Entered Column
+|project=Anti-Harassment (The Letter Song)
+|column=QA/Testing 🐞
+}}{{Transition
+|date=1592321804
+|type=Exited Column
+|project=Anti-Harassment (The Letter Song)
+|column=Code Review 🔍
+}}{{Transition
+|date=1592320213
+|type=Removed Project
+|project=Patch-For-Review
+}}{{Transition
+|date=1591640595
+|type=Entered Column
+|project=User-Urbanecm
+|column=Waiting on review
+}}{{Transition
+|date=1591640595
+|type=Exited Column
+|project=User-Urbanecm
+|column=Working on
+}}{{Transition
+|date=1589468817
+|type=Entered Column
+|project=Anti-Harassment (The Letter Song)
+|column=Code Review 🔍
+}}{{Transition
+|date=1589468817
+|type=Exited Column
+|project=Anti-Harassment (The Letter Song)
+|column=Code Review 🔍
+}}{{Transition
+|date=1589306500
+|type=Entered Column
+|project=User-Urbanecm
+|column=Working on
+}}{{Transition
+|date=1589306500
+|type=Exited Column
+|project=User-Urbanecm
+|column=Backlog
+}}{{Transition
+|date=1588932569
+|type=Removed Project
+|project=Platform Team Workboards (Clinic Duty Team)
+}}{{Transition
+|date=1588932569
+|type=Added Project
+|project=Platform Team Workboards (External Code Reviews)
+}}{{Transition
 |date=1588878739
 |type=Added Project
@@ Line 52: / Line 120: @@
 |type=Entered Column
 |project=Anti-Harassment (The Letter Song)
-|column=Review
+|column=Code Review 🔍
 }}{{Transition
 |date=1588669140
 |type=Exited Column
 |project=Anti-Harassment (The Letter Song)
-|column=Ready
+|column=Ready 🎬  (ONLY IF YOU HAVE NO MORE CODE TO REVIEW)
 }}{{Transition
 |date=1588666140
@@ Line 69: / Line 137: @@
 |date=1588666140
 |type=Added Project
-|project=Core Platform Team Workboards (Clinic Duty Team)
+|project=Platform Team Workboards (Clinic Duty Team)
 }}{{Transition
 |date=1588666140
 |type=Added Project
-|project=CPT Initiatives (Decoupling (CDP2))
+|project=Platform Team Initiatives (Decoupling (CDP2))
 }}{{Transition
 |date=1588666140