Difference between revisions of "T203587: Major overhaul for "throttle" action in AbuseFilter"

Revision as of 08:37, 2 March 2020

Phabricator Link	T203587
Status	open
Priority	Medium (orange)
Points
Phabricator Task Created	2018/09/05 01:36 PM
Wiki Page Created	2019/06/09 01:20 PM
Phabricator Task Last Modified	2019/09/10 02:27 PM
Wiki Page Last Updated	2021/02/05 12:16 PM
Phabricator Task Closed
Authored By	Daimona
Assigned To
Projects	AbuseFilter (Backlog) Technical-Debt (Unsorted)
Platform Engineering Initiative Column
Platform Team Workboards Column
Subtasks	T203535: PHP Error "Undefined index: 1 in AbuseFilter.php on line 928" (resolved) T203336: Fatal exception when editing an abuse filter: Error: 1048 Column 'afa_parameters' cannot be null (resolved) T215787: PHP Warning: "count(): Parameter must be an array or an object that implements Countable" on AbuseFilter history with PHP7 (resolved) T211101: Throttle identifiers are ambiguous (open) T203585: Throttle parameters may have an undesired comma inside (resolved) T203584: Throttle groups may be empty or include unknown stuff (resolved) T203554: Rewrite throttle parameters (open) T203359: Simplify throttle-related method after maintenance script execution (invalid) T196995: Should we log filter hits for actions that were only throttled? (open) T195699: "Throttle" action seems to malfunction randomly (resolved) T24623: do not set throttle on warn action (open)
Parent Tasks

Column Transitions: (Added project: ⇑, Removed project: ⇓,Entered column: ⇒, Exited column: ⇐)

Project	Column	Date
⇑ Technical-Debt		5 September 2018
⇑ AbuseFilter		5 September 2018
⇑ Core-Platform-Team-Old		5 September 2018
⇑ Patch-For-Review		9 September 2018
⇓ Core-Platform-Team-Old		11 September 2018
Core-Platform-Team-Old	⇐ Inbox	11 September 2018
Core-Platform-Team-Old	⇒ CPT-Q1-Jul-Sep-2018	11 September 2018
⇑ Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018)		11 September 2018
Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018)	⇐ Backlog	11 September 2018
Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018)	⇒ Waiting for Review	11 September 2018
⇑ User-Daimona		16 September 2018
User-Daimona	⇐ Backlog	16 September 2018
User-Daimona	⇒ Under review	16 September 2018
⇓ Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018)		1 October 2018
⇑ Platform Team Legacy (Designing)		1 October 2018
Platform Team Legacy (Designing)	⇐ Inbox	1 October 2018
Platform Team Legacy (Designing)	⇒ Waiting for Review	1 October 2018
⇑ Platform Engineering		2 October 2018
Platform Team Legacy	⇐ Designing	2 October 2018
Platform Team Legacy	⇒ Designing	2 October 2018
⇓ Platform Engineering		3 October 2018
Platform Engineering	⇐ Inbox	3 October 2018
Platform Engineering	⇒ Needs Cleaning - Code Health (TEC13)	3 October 2018
⇑ Platform Engineering (Needs Cleaning - Code Health (TEC13))		3 October 2018
⇓ Platform Team Legacy (Designing)		14 October 2018
⇑ Platform Team Workboards (Waiting for Review)		14 October 2018
Platform Engineering	⇐ Needs Cleaning - Code Health (TEC13)	8 November 2018
Platform Engineering	⇒ Needs Cleaning - Code Health (TEC13)	8 November 2018
Platform Team Workboards	⇐ Waiting for Review	17 January 2019
Platform Team Workboards	⇒ Waiting for Review	17 January 2019
⇓ Platform Team Workboards (Waiting for Review)		22 January 2019
Platform Team Workboards	⇐ Waiting for Review	22 January 2019
Platform Team Workboards	⇒ Blocked Externally	22 January 2019
⇑ Platform Team Workboards (Blocked Externally)		22 January 2019
Platform Team Workboards	⇐ Blocked Externally	25 January 2019
Platform Team Workboards	⇒ Blocked Externally	25 January 2019
⇓ Platform Team Workboards (Blocked Externally)		5 July 2019
⇓ Platform Engineering (Needs Cleaning - Code Health (TEC13))		10 September 2019
⇑ Platform Engineering		10 September 2019
⇓ Platform Engineering		10 September 2019
User-Daimona	⇐ Under review	20 August 2020
User-Daimona	⇒ Ideas for overhaul	20 August 2020
⇓ User-Daimona		16 September 2020
⇓ AbuseFilter		16 September 2020
⇑ AbuseFilter (Overhaul-2020)		16 September 2020
AbuseFilter (Overhaul-2020)	⇐ Backlog	16 September 2020
AbuseFilter (Overhaul-2020)	⇒ Stretch	16 September 2020
⇓ Patch-For-Review		15 October 2020
⇓ AbuseFilter (Overhaul-2020)		5 February 2021
⇑ AbuseFilter		5 February 2021

@@ Line 34: / Line 34: @@
 |subtasks=203336,215787,211101,203585,203584,203554,203359,196995,203535,195699,24623
 |transitions={{Transition
+|date=1568140058
+|type=Removed Project
+|project=Core Platform Team
+}}{{Transition
+|date=1568139991
+|type=Removed Project
+|project=Needs Cleaning - Code Health (TEC13)
+}}{{Transition
+|date=1568139991
+|type=Added Project
+|project=Core Platform Team
+}}{{Transition
+|date=1562353325
+|type=Removed Project
+|project=Blocked Externally
+}}{{Transition
+|date=1548427425
+|type=Entered Column
 |project=Core Platform Team Workboards
 |column=Blocked Externally
-|transitionDate=1548427425
-|transitionType=Entered Column
 }}{{Transition
+|date=1548427425
+|type=Exited Column
 |project=Core Platform Team Workboards
 |column=Blocked Externally
-|transitionDate=1548427425
-|transitionType=Exited Column
 }}{{Transition
+|date=1548171689
+|type=Removed Project
+|project=Waiting for Review
+}}{{Transition
+|date=1548171689
+|type=Added Project
+|project=Blocked Externally
+}}{{Transition
+|date=1548171689
+|type=Entered Column
 |project=Core Platform Team Workboards
 |column=Blocked Externally
-|transitionDate=1548171689
-|transitionType=Entered Column
 }}{{Transition
+|date=1548171689
+|type=Exited Column
 |project=Core Platform Team Workboards
 |column=Waiting for Review
-|transitionDate=1548171689
-|transitionType=Exited Column
 }}{{Transition
+|date=1547747696
+|type=Entered Column
 |project=Core Platform Team Workboards
 |column=Waiting for Review
-|transitionDate=1547747696
-|transitionType=Entered Column
 }}{{Transition
+|date=1547747696
+|type=Exited Column
 |project=Core Platform Team Workboards
 |column=Waiting for Review
-|transitionDate=1547747696
-|transitionType=Exited Column
 }}{{Transition
+|date=1541719578
+|type=Entered Column
 |project=Core Platform Team
 |column=Needs Cleaning - Code Health (TEC13)
-|transitionDate=1541719578
-|transitionType=Entered Column
 }}{{Transition
+|date=1541719578
+|type=Exited Column
 |project=Core Platform Team
 |column=Needs Cleaning - Code Health (TEC13)
-|transitionDate=1541719578
-|transitionType=Exited Column
 }}{{Transition
+|date=1539531616
+|type=Removed Project
+|project=Designing
+}}{{Transition
+|date=1539531616
+|type=Added Project
+|project=Waiting for Review
+}}{{Transition
+|date=1538575878
+|type=Removed Project
+|project=Core Platform Team
+}}{{Transition
+|date=1538575878
+|type=Added Project
+|project=Needs Cleaning - Code Health (TEC13)
+}}{{Transition
+|date=1538575878
+|type=Entered Column
 |project=Core Platform Team
 |column=Needs Cleaning - Code Health (TEC13)
-|transitionDate=1538575878
-|transitionType=Entered Column
 }}{{Transition
+|date=1538575878
+|type=Exited Column
 |project=Core Platform Team
 |column=Inbox
-|transitionDate=1538575878
-|transitionType=Exited Column
 }}{{Transition
+|date=1538504751
+|type=Entered Column
 |project=Core Platform Team Legacy
 |column=Designing
-|transitionDate=1538504751
-|transitionType=Entered Column
 }}{{Transition
+|date=1538504751
+|type=Exited Column
 |project=Core Platform Team Legacy
 |column=Designing
-|transitionDate=1538504751
-|transitionType=Exited Column
 }}{{Transition
+|date=1538490338
+|type=Added Project
+|project=Core Platform Team
+}}{{Transition
+|date=1538399777
+|type=Entered Column
 |project=Core Platform Team Legacy (Designing)
 |column=Waiting for Review
-|transitionDate=1538399777
-|transitionType=Entered Column
 }}{{Transition
+|date=1538399777
+|type=Exited Column
 |project=Core Platform Team Legacy (Designing)
 |column=Inbox
-|transitionDate=1538399777
-|transitionType=Exited Column
 }}{{Transition
+|date=1538399690
+|type=Removed Project
+|project=CPT-Q1-Jul-Sep-2018
+}}{{Transition
+|date=1538399690
+|type=Added Project
+|project=Designing
+}}{{Transition
+|date=1537113699
+|type=Entered Column
 |project=User-Daimona
 |column=Under review
-|transitionDate=1537113699
-|transitionType=Entered Column
 }}{{Transition
+|date=1537113699
+|type=Exited Column
 |project=User-Daimona
 |column=Backlog
-|transitionDate=1537113699
-|transitionType=Exited Column
 }}{{Transition
+|date=1537113690
+|type=Added Project
+|project=User-Daimona
+}}{{Transition
+|date=1536715200
+|type=Entered Column
 |project=Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018)
 |column=Waiting for Review
-|transitionDate=1536715200
-|transitionType=Entered Column
 }}{{Transition
+|date=1536715200
+|type=Exited Column
 |project=Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018)
 |column=Backlog
-|transitionDate=1536715200
-|transitionType=Exited Column
 }}{{Transition
+|date=1536715164
+|type=Removed Project
+|project=Core-Platform-Team-Old
+}}{{Transition
+|date=1536715164
+|type=Added Project
+|project=CPT-Q1-Jul-Sep-2018
+}}{{Transition
+|date=1536715164
+|type=Entered Column
 |project=Core-Platform-Team-Old
 |column=CPT-Q1-Jul-Sep-2018
-|transitionDate=1536715164
-|transitionType=Entered Column
 }}{{Transition
+|date=1536715164
+|type=Exited Column
 |project=Core-Platform-Team-Old
 |column=Inbox
-|transitionDate=1536715164
+}}{{Transition
-|transitionType=Exited Column
+|date=1536488256
+|type=Added Project
+|project=Patch-For-Review
+}}{{Transition
+|date=1536169233
+|type=Added Project
+|project=Core-Platform-Team-Old
+}}{{Transition
+|date=1536169010
+|type=Added Project
+|project=AbuseFilter
+}}{{Transition
+|date=1536169010
+|type=Added Project
+|project=Technical-Debt
 }}
 }}